# HG changeset patch # User Chris Jones # Date 1325565642 25200 # Node ID 9b664fde0ec384971c3bfef5ea2269b37fe8a822 # Parent 1af366d10d32215a12f6ad26335c59875398bf98 Comment fixes. diff -r 1af366d10d32 -r 9b664fde0ec3 roster.go --- a/roster.go Mon Jan 02 13:18:48 2012 -0700 +++ b/roster.go Mon Jan 02 21:40:42 2012 -0700 @@ -91,6 +91,7 @@ // will fail in practice. Either the roster should be protected with a // mutex, or we should make the roster available on a channel instead // of via a method call. +// BUG(cjyar) RFC 3921, Section 7.4 says we need to reply. func (cl *Client) maybeUpdateRoster(st Stanza) { rq, ok := st.GetNested().(*RosterQuery) if st.GetName() == "iq" && st.GetType() == "set" && ok { diff -r 1af366d10d32 -r 9b664fde0ec3 structs.go --- a/structs.go Mon Jan 02 13:18:48 2012 -0700 +++ b/structs.go Mon Jan 02 21:40:42 2012 -0700 @@ -187,6 +187,8 @@ return result } +// Set implements flag.Value. It returns true if it successfully +// parses the string. func (jid *JID) Set(val string) bool { r := regexp.MustCompile("^(([^@/]+)@)?([^@/]+)(/([^@/]+))?$") parts := r.FindStringSubmatch(val)