--- a/stream.go Sun Jan 08 09:11:14 2012 -0700
+++ b/stream.go Sun Jan 08 13:04:09 2012 -0700
@@ -37,8 +37,8 @@
// BUG(cjyar) Review all these *Client receiver methods. They should
// probably either all be receivers, or none.
-func (cl *Client) readTransport(w io.Writer) {
- defer tryClose(cl.socket, w)
+func (cl *Client) readTransport(w io.WriteCloser) {
+ defer w.Close()
cl.socket.SetReadTimeout(1e8)
p := make([]byte, 1024)
for {
@@ -68,7 +68,7 @@
}
func (cl *Client) writeTransport(r io.Reader) {
- defer tryClose(r, cl.socket)
+ defer cl.socket.Close()
p := make([]byte, 1024)
for {
nr, err := r.Read(p)
@@ -95,9 +95,10 @@
go tee(r, pw, "S: ")
r = pr
}
- defer tryClose(r, ch)
+ defer close(ch)
p := xml.NewParser(r)
+Loop:
for {
// Sniff the next token on the stream.
t, err := p.Token()
@@ -125,7 +126,7 @@
Log.Err("unmarshal stream: " +
err.String())
}
- break
+ break Loop
}
ch <- st
continue
@@ -158,7 +159,7 @@
if Log != nil {
Log.Err("unmarshal: " + err.String())
}
- break
+ break Loop
}
// If it's a Stanza, we try to unmarshal its innerxml
@@ -171,7 +172,7 @@
Log.Err("ext unmarshal: " +
err.String())
}
- break
+ break Loop
}
}
@@ -218,7 +219,11 @@
go tee(pr, w, "C: ")
w = pw
}
- defer tryClose(w, ch)
+ defer func(w io.Writer) {
+ if c, ok := w.(io.Closer) ; ok {
+ c.Close()
+ }
+ }(w)
for obj := range ch {
err := xml.Marshal(w, obj)
@@ -232,16 +237,17 @@
}
func (cl *Client) readStream(srvIn <-chan interface{}, cliOut chan<- Stanza) {
- defer tryClose(srvIn, cliOut)
+ defer close(cliOut)
handlers := make(map[string] func(Stanza) bool)
+Loop:
for {
select {
case h := <- cl.handlers:
handlers[h.id] = h.f
- case x := <- srvIn:
- if x == nil {
- break
+ case x, ok := <- srvIn:
+ if !ok {
+ break Loop
}
send := false
switch obj := x.(type) {
@@ -287,9 +293,10 @@
// activity.
func writeStream(srvOut chan<- interface{}, cliIn <-chan Stanza,
control <-chan int) {
- defer tryClose(srvOut, cliIn)
+ defer close(srvOut)
var input <-chan Stanza
+Loop:
for {
select {
case status := <- control:
@@ -299,9 +306,12 @@
case 1:
input = cliIn
case -1:
- break
+ break Loop
}
- case x := <- input:
+ case x, ok := <- input:
+ if !ok {
+ break Loop
+ }
if x == nil {
if Log != nil {
Log.Notice("Refusing to send" +
@@ -319,6 +329,7 @@
func filterTop(filterOut <-chan <-chan Stanza, filterIn chan<- <-chan Stanza,
topFilter <-chan Stanza, app chan<- Stanza) {
defer close(app)
+Loop:
for {
select {
case newFilterOut := <- filterOut:
@@ -334,7 +345,7 @@
case data, ok := <-topFilter:
if !ok {
- break
+ break Loop
}
app <- data
}
@@ -355,7 +366,7 @@
if Log != nil {
Log.Notice(fmt.Sprintf("Received stream error: %v", se))
}
- cl.Close()
+ close(cl.Out)
}
func (cl *Client) handleFeatures(fe *Features) {