dwm: comparison dwm.c

equal deleted inserted replaced

-:b561ed2a0fc1
+:4cbf60555bd8
+/* TODO: cleanup nexttiled, ISVISIBLE, etc */
 /* See LICENSE file for copyright and license details.
 *
 * dynamic window manager is designed like any other X client as well. It is
 * driven through handling X events. In contrast to other X clients, a window
 * manager selects for SubstructureRedirectMask on the root window, to receive
 /* macros */
 #define BUTTONMASK              (ButtonPressMask|ButtonReleaseMask)
 #define CLEANMASK(mask)         (mask & ~(numlockmask|LockMask))
 #define INRECT(X,Y,RX,RY,RW,RH) ((X) >= (RX) && (X) < (RX) + (RW) && (Y) >= (RY) && (Y) < (RY) + (RH))
-#define ISVISIBLE(M, C)         ((M) == (C->m) && (C->tags & M->tagset[M->seltags]))
+#define ISVISIBLE(M, C)         ((M) == (C->mon) && (C->tags & M->tagset[M->seltags]))
 #define LENGTH(X)               (sizeof X / sizeof X[0])
 #define MAX(A, B)               ((A) > (B) ? (A) : (B))
 #define MIN(A, B)               ((A) < (B) ? (A) : (B))
 #define MOUSEMASK               (BUTTONMASK|PointerMotionMask)
 #define WIDTH(X)                ((X)->w + 2 * (X)->bw)
 	int bw, oldbw;
 	unsigned int tags;
 	Bool isfixed, isfloating, isurgent;
 	Client *next;
 	Client *snext;
-	Monitor *m;
+	Monitor *mon;
 	Window win;
 };
 typedef struct {
 	int x, y, w, h;
 	unsigned int seltags;
 	unsigned int sellt;
 	unsigned int tagset[2];
 	Bool showbar;
 	Bool topbar;
+	Client *clients;
+	Client *sel;
+	Client *stack;
+	Monitor *next;
 	Window barwin;
-	Monitor *next;
 };
 typedef struct {
 	const char *class;
 	const char *instance;
 	[UnmapNotify] = unmapnotify
 };
 static Atom wmatom[WMLast], netatom[NetLast];
 static Bool otherwm;
 static Bool running = True;
-static Client *clients = NULL;
-static Client *sel = NULL;
-static Client *stack = NULL;
 static Cursor cursor[CurLast];
 static Display *dpy;
 static DC dc;
 static Layout *lt[] = { NULL, NULL };
 static Monitor *mons = NULL, *selmon = NULL;
 		if(ch.res_class)
 			XFree(ch.res_class);
 		if(ch.res_name)
 			XFree(ch.res_name);
 	}
-	c->tags = c->tags & TAGMASK ? c->tags & TAGMASK : c->m->tagset[c->m->seltags];
+	c->tags = c->tags & TAGMASK ? c->tags & TAGMASK : c->mon->tagset[c->mon->seltags];
 }
 Bool
 applysizehints(Client *c, int *x, int *y, int *w, int *h) {
 	Bool baseismin;
 void
 arrange(void) {
 	Monitor *m;
-	showhide(stack);
+	/* optimise two loops into one, check focus(NULL) */
+	for(m = mons; m; m = m->next)
+		showhide(m->stack);
 	focus(NULL);
 	for(m = mons; m; m = m->next) {
 		if(lt[m->sellt]->arrange)
 			lt[m->sellt]->arrange(m);
 		restack(m);
 	}
 }
 void
 attach(Client *c) {
-	c->next = clients;
+	c->next = selmon->clients;
-	clients = c;
+	selmon->clients = c;
 }
 void
 attachstack(Client *c) {
-	c->snext = stack;
+	c->snext = selmon->stack;
-	stack = c;
+	selmon->stack = c;
 }
 void
 buttonpress(XEvent *e) {
 	unsigned int i, x, click;
 void
 cleanup(void) {
 	Arg a = {.ui = ~0};
 	Layout foo = { "", NULL };
+	Monitor *m;
 	view(&a);
 	lt[selmon->sellt] = &foo;
-	while(stack)
-		unmanage(stack);
+	/* TODO: consider simplifying cleanup code of the stack, perhaps do that in cleanmons() ? */
+	for(m = mons; m; m = m->next)
+		while(m->stack)
+			unmanage(m->stack);
 	if(dc.font.set)
 		XFreeFontSet(dpy, dc.font.set);
 	else
 		XFreeFont(dpy, dc.font.xfont);
 	XUngrabKey(dpy, AnyKey, AnyModifier, root);
 				c->x = sx + (sw / 2 - c->w / 2); /* center in x direction */
 			if((c->y - sy + c->h) > sh && c->isfloating)
 				c->y = sy + (sh / 2 - c->h / 2); /* center in y direction */
 			if((ev->value_mask & (CWX|CWY)) && !(ev->value_mask & (CWWidth|CWHeight)))
 				configure(c);
-			if(ISVISIBLE((c->m), c))
+			if(ISVISIBLE((c->mon), c))
 				XMoveResizeWindow(dpy, c->win, c->x, c->y, c->w, c->h);
 		}
 		else
 			configure(c);
 	}
 void
 detach(Client *c) {
 	Client **tc;
-	for(tc = &clients; *tc && *tc != c; tc = &(*tc)->next);
+	for(tc = &c->mon->clients; *tc && *tc != c; tc = &(*tc)->next);
 	*tc = c->next;
 }
 void
 detachstack(Client *c) {
 	Client **tc;
-	for(tc = &stack; *tc && *tc != c; tc = &(*tc)->snext);
+	for(tc = &c->mon->stack; *tc && *tc != c; tc = &(*tc)->snext);
 	*tc = c->snext;
 }
 void
 die(const char *errstr, ...) {
 	int x;
 	unsigned int i, occ = 0, urg = 0;
 	unsigned long *col;
 	Client *c;
-	for(c = clients; c; c = c->next) {
+	for(c = m->clients; c; c = c->next) {
-		if(m == c->m) {
+		occ |= c->tags;
-			occ |= c->tags;
+		if(c->isurgent)
-			if(c->isurgent)
+			urg |= c->tags;
-				urg |= c->tags;
-		}
 	}
 	dc.x = 0;
 #ifdef XINERAMA
 	{
 	m->btx = dc.x;
 	for(i = 0; i < LENGTH(tags); i++) {
 		dc.w = TEXTW(tags[i]);
 		col = m->tagset[m->seltags] & 1 << i ? dc.sel : dc.norm;
 		drawtext(tags[i], col, urg & 1 << i);
-		drawsquare(m == selmon && sel && sel->tags & 1 << i,
+		drawsquare(m == selmon && selmon->sel && selmon->sel->tags & 1 << i,
 		           occ & 1 << i, urg & 1 << i, col);
 		dc.x += dc.w;
 	}
 	if(blw > 0) {
 		dc.w = blw;
 			dc.w = m->ww - x;
 		}
 		drawtext(stext, dc.norm, False);
 		if((dc.w = dc.x - x) > bh) {
 			dc.x = x;
-			if(sel) {
+			if(selmon->sel) {
-				drawtext(sel->name, dc.sel, False);
+				drawtext(selmon->sel->name, dc.sel, False);
-				drawsquare(sel->isfixed, sel->isfloating, False, dc.sel);
+				drawsquare(selmon->sel->isfixed, selmon->sel->isfloating, False, dc.sel);
 			}
 			else
 				drawtext(NULL, dc.norm, False);
 		}
 	}
 			}
 }
 void
 focus(Client *c) {
-	if(!c || !ISVISIBLE((c->m), c))
+	if(!c || !ISVISIBLE((c->mon), c))
-		for(c = stack; c && !ISVISIBLE(selmon, c); c = c->snext);
+		for(c = selmon->stack; c && !ISVISIBLE(selmon, c); c = c->snext);
-	if(sel && sel != c) {
+	if(selmon->sel && selmon->sel != c) {
-		grabbuttons(sel, False);
+		grabbuttons(selmon->sel, False);
-		XSetWindowBorder(dpy, sel->win, dc.norm[ColBorder]);
+		XSetWindowBorder(dpy, selmon->sel->win, dc.norm[ColBorder]);
 	}
 	if(c) {
 		if(c->isurgent)
 			clearurgent(c);
 		detachstack(c);
 		XSetWindowBorder(dpy, c->win, dc.sel[ColBorder]);
 		XSetInputFocus(dpy, c->win, RevertToPointerRoot, CurrentTime);
 	}
 	else
 		XSetInputFocus(dpy, root, RevertToPointerRoot, CurrentTime);
-	sel = c;
+	selmon->sel = c;
 	drawbars();
 }
 void
 focusin(XEvent *e) { /* there are some broken focus acquiring clients */
 	XFocusChangeEvent *ev = &e->xfocus;
-	if(sel && ev->window != sel->win)
+	if(selmon->sel && ev->window != selmon->sel->win)
-		XSetInputFocus(dpy, sel->win, RevertToPointerRoot, CurrentTime);
+		XSetInputFocus(dpy, selmon->sel->win, RevertToPointerRoot, CurrentTime);
 }
 #ifdef XINERAMA
 void
 focusmon(const Arg *arg) {
 void
 focusstack(const Arg *arg) {
 	Client *c = NULL, *i;
-	if(!sel)
+	if(!selmon->sel)
 		return;
 	if(arg->i > 0) {
-		for(c = sel->next; c && !ISVISIBLE(selmon, c); c = c->next);
+		for(c = selmon->sel->next; c && !ISVISIBLE(selmon, c); c = c->next);
 		if(!c)
-			for(c = clients; c && !ISVISIBLE(selmon, c); c = c->next);
+			for(c = selmon->clients; c && !ISVISIBLE(selmon, c); c = c->next);
 	}
 	else {
-		for(i = clients; i != sel; i = i->next)
+		for(i = selmon->clients; i != selmon->sel; i = i->next)
 			if(ISVISIBLE(selmon, i))
 				c = i;
 		if(!c)
 			for(; i; i = i->next)
 				if(ISVISIBLE(selmon, i))
 	}
 }
 Client *
 getclient(Window w) {
-	Client *c;
+	Client *c = NULL;
+	Monitor *m;
-	for(c = clients; c && c->win != w; c = c->next);
+	for(m = mons; m; m = m->next)
+		for(c = m->clients; c && c->win != w; c = c->next);
 	return c;
 }
 unsigned long
 getcolor(const char *colstr) {
 void
 killclient(const Arg *arg) {
 	XEvent ev;
-	if(!sel)
+	if(!selmon->sel)
 		return;
-	if(isprotodel(sel)) {
+	if(isprotodel(selmon->sel)) {
 		ev.type = ClientMessage;
-		ev.xclient.window = sel->win;
+		ev.xclient.window = selmon->sel->win;
 		ev.xclient.message_type = wmatom[WMProtocols];
 		ev.xclient.format = 32;
 		ev.xclient.data.l[0] = wmatom[WMDelete];
 		ev.xclient.data.l[1] = CurrentTime;
-		XSendEvent(dpy, sel->win, False, NoEventMask, &ev);
+		XSendEvent(dpy, selmon->sel->win, False, NoEventMask, &ev);
 	}
 	else
-		XKillClient(dpy, sel->win);
+		XKillClient(dpy, selmon->sel->win);
 }
 void
 manage(Window w, XWindowAttributes *wa) {
 	static Client cz;
 	if(!(c = malloc(sizeof(Client))))
 		die("fatal: could not malloc() %u bytes\n", sizeof(Client));
 	*c = cz;
 	c->win = w;
-	c->m = selmon;
+	c->mon = selmon;
 	/* geometry */
 	c->x = wa->x;
 	c->y = wa->y;
 	c->w = wa->width;
 void
 monocle(Monitor *m) {
 	Client *c;
-	for(c = nexttiled(m, clients); c; c = nexttiled(m, c->next))
+	for(c = nexttiled(m, selmon->clients); c; c = nexttiled(m, c->next))
 		resize(c, m->wx, m->wy, m->ww - 2 * c->bw, m->wh - 2 * c->bw);
 }
 void
 movemouse(const Arg *arg) {
 	unsigned int dui;
 	Client *c;
 	Window dummy;
 	XEvent ev;
-	if(!(c = sel))
+	if(!(c = selmon->sel))
 		return;
 	restack(selmon);
 	ocx = c->x;
 	ocy = c->y;
 	if(XGrabPointer(dpy, root, False, MOUSEMASK, GrabModeAsync, GrabModeAsync,
 			drawbars();
 			break;
 		}
 		if(ev->atom == XA_WM_NAME || ev->atom == netatom[NetWMName]) {
 			updatetitle(c);
-			if(c == sel)
+			if(c == selmon->sel)
 				drawbars();
 		}
 	}
 }
 	int ocx, ocy;
 	int nw, nh;
 	Client *c;
 	XEvent ev;
-	if(!(c = sel))
+	if(!(c = selmon->sel))
 		return;
 	restack(selmon);
 	ocx = c->x;
 	ocy = c->y;
 	if(XGrabPointer(dpy, root, False, MOUSEMASK, GrabModeAsync, GrabModeAsync,
 	Client *c;
 	XEvent ev;
 	XWindowChanges wc;
 	drawbars();
-	if(!sel)
+	if(!selmon->sel)
 		return;
-	if(m == selmon && (sel->isfloating || !lt[m->sellt]->arrange))
+	if(m == selmon && (selmon->sel->isfloating || !lt[m->sellt]->arrange))
-		XRaiseWindow(dpy, sel->win);
+		XRaiseWindow(dpy, selmon->sel->win);
 	if(lt[m->sellt]->arrange) {
 		wc.stack_mode = Below;
 		wc.sibling = m->barwin;
-		for(c = stack; c; c = c->snext)
+		for(c = m->stack; c; c = c->snext)
 			if(!c->isfloating && ISVISIBLE(m, c)) {
 				XConfigureWindow(dpy, c->win, CWSibling|CWStackMode, &wc);
 				wc.sibling = c->win;
 			}
 	}
 setlayout(const Arg *arg) {
 	if(!arg || !arg->v || arg->v != lt[selmon->sellt])
 		selmon->sellt ^= 1;
 	if(arg && arg->v)
 		lt[selmon->sellt] = (Layout *)arg->v;
-	if(sel)
+	if(selmon->sel)
 		arrange();
 	else
 		drawbars();
 }
 void
 showhide(Client *c) {
 	if(!c)
 		return;
-	if(ISVISIBLE((c->m), c)) { /* show clients top down */
+	if(ISVISIBLE((c->mon), c)) { /* show clients top down */
 		XMoveWindow(dpy, c->win, c->x, c->y);
-		if(!lt[c->m->sellt]->arrange || c->isfloating)
+		if(!lt[c->mon->sellt]->arrange || c->isfloating)
 			resize(c, c->x, c->y, c->w, c->h);
 		showhide(c->snext);
 	}
 	else { /* hide clients bottom up */
 		showhide(c->snext);
 	}
 }
 void
 tag(const Arg *arg) {
-	if(sel && arg->ui & TAGMASK) {
+	if(selmon->sel && arg->ui & TAGMASK) {
-		sel->tags = arg->ui & TAGMASK;
+		selmon->sel->tags = arg->ui & TAGMASK;
 		arrange();
 	}
 }
 #ifdef XINERAMA
 	unsigned int i;
 	Monitor *m;
 	for(i = 0, m = mons; m; m = m->next, i++)
 		if(i == arg->ui) {
-			sel->m = m;
+			selmon->sel->m = m;
 			arrange();
 			break;
 		}
 }
 #endif /* XINERAMA */
 tile(Monitor *m) {
 	int x, y, h, w, mw;
 	unsigned int i, n;
 	Client *c;
-	for(n = 0, c = nexttiled(m, clients); c; c = nexttiled(m, c->next), n++);
+	for(n = 0, c = nexttiled(m, m->clients); c; c = nexttiled(m, c->next), n++);
 	if(n == 0)
 		return;
 	/* master */
-	c = nexttiled(m, clients);
+	c = nexttiled(m, m->clients);
 	mw = m->mfact * m->ww;
 	resize(c, m->wx, m->wy, (n == 1 ? m->ww : mw) - 2 * c->bw, m->wh - 2 * c->bw);
 	if(--n == 0)
 		return;
 	arrange();
 }
 void
 togglefloating(const Arg *arg) {
-	if(!sel)
+	if(!selmon->sel)
 		return;
-	sel->isfloating = !sel->isfloating || sel->isfixed;
+	selmon->sel->isfloating = !selmon->sel->isfloating || selmon->sel->isfixed;
-	if(sel->isfloating)
+	if(selmon->sel->isfloating)
-		resize(sel, sel->x, sel->y, sel->w, sel->h);
+		resize(selmon->sel, selmon->sel->x, selmon->sel->y, selmon->sel->w, selmon->sel->h);
 	arrange();
 }
 void
 toggletag(const Arg *arg) {
 	unsigned int mask;
-	if(!sel)
+	if(!selmon->sel)
 		return;
-	mask = sel->tags ^ (arg->ui & TAGMASK);
+	mask = selmon->sel->tags ^ (arg->ui & TAGMASK);
 	if(mask) {
-		sel->tags = mask;
+		selmon->sel->tags = mask;
 		arrange();
 	}
 }
 void
 	XGrabServer(dpy);
 	XSetErrorHandler(xerrordummy);
 	XConfigureWindow(dpy, c->win, CWBorderWidth, &wc); /* restore border */
 	detach(c);
 	detachstack(c);
-	if(sel == c)
+	if(selmon->sel == c)
 		focus(NULL);
 	XUngrabButton(dpy, AnyButton, AnyModifier, c->win);
 	setclientstate(c, WithdrawnState);
 	free(c);
 	XSync(dpy, False);
 void
 updategeom(void) {
 	int i, n = 1;
 	Client *c;
-	Monitor *newmons = NULL, *m;
+	Monitor *newmons = NULL, *m, *tm;
 #ifdef XINERAMA
 	XineramaScreenInfo *info = NULL;
 	if(XineramaIsActive(dpy))
 	}
 	/* bar geometry setup */
 	for(m = newmons; m; m = m->next) {
 		/* TODO: consider removing the following values from config.h */
+		m->clients = NULL;
+		m->sel = NULL;
+		m->stack = NULL;
 		m->seltags = 0;
 		m->sellt = 0;
 		m->tagset[0] = m->tagset[1] = 1;
 		m->mfact = mfact;
 		m->showbar = showbar;
 		m->topbar = topbar;
 		updatebarpos(m);
 		/* reassign all clients with same screen number */
-		for(c = clients; c; c = c->next)
+		for(tm = mons; tm; tm = tm->next)
-			if(c->m->screen_number == m->screen_number)
+			if(tm->screen_number == m->screen_number) {
-				c->m = m;
+				m->clients = tm->clients;
-	}
+				m->stack = tm->stack;
+				tm->clients = NULL;
-	/* reassign left over clients with disappeared screen number */
+				tm->stack = NULL;
-	for(c = clients; c; c = c->next)
+				for(c = m->clients; c; c = c->next)
-		if(c->m->screen_number >= n)
+					c->mon = m;
-			c->m = newmons;
+			}
+	}
+	/* reassign left over clients of disappeared monitors */
+	for(tm = mons; tm; tm = tm->next) {
+		while(tm->clients) {
+			c = tm->clients->next;
+			tm->clients->next = newmons->clients;
+			tm->clients->mon = newmons;
+			newmons->clients = tm->clients;
+			tm->clients = c;
+		}
+		while(tm->stack) {
+			c = tm->stack->snext;
+			tm->stack->snext = newmons->stack;
+			newmons->stack = tm->stack;
+			tm->stack = c;
+		}
+	}
 	/* select focused monitor */
 	if(!selmon) {
 		selmon = newmons;
 		int di, x, y;
 void
 updatewmhints(Client *c) {
 	XWMHints *wmh;
 	if((wmh = XGetWMHints(dpy, c->win))) {
-		if(c == sel && wmh->flags & XUrgencyHint) {
+		if(c == selmon->sel && wmh->flags & XUrgencyHint) {
 			wmh->flags &= ~XUrgencyHint;
 			XSetWMHints(dpy, c->win, wmh);
 		}
 		else
 			c->isurgent = (wmh->flags & XUrgencyHint) ? True : False;
 	return -1;
 }
 void
 zoom(const Arg *arg) {
-	Client *c = sel;
+	Client *c = selmon->sel;
-	if(!lt[selmon->sellt]->arrange || lt[selmon->sellt]->arrange == monocle || (sel && sel->isfloating))
+	if(!lt[selmon->sellt]->arrange || lt[selmon->sellt]->arrange == monocle || (selmon->sel && selmon->sel->isfloating))
 		return;
-	if(c == nexttiled(selmon, clients))
+	if(c == nexttiled(selmon, selmon->clients))
 		if(!c || !(c = nexttiled(selmon, c->next)))
 			return;
 	detach(c);
 	attach(c);
 	focus(c);

changeset 1407	4cbf60555bd8
parent 1406	b561ed2a0fc1
child 1408	2215f7f11dd9